proftpd 'check server security' minor bug fix

[Shmoopy]

I believe I may have fixed a minor bug in the "Check Server Security" script. On my server at least, the "Check proftpd weak SSL/TLS Ciphers" test was giving a false positive. I managed to track down the issue to the regexp on line 645 of servercheck.pm.

Code: Select all

/TLSCipherSuite\s+(.*)$/

on my server, works better as:

Code: Select all

/TLSCipherSuite:\s+(.*)$/

Note the added colon. Without it the $ciphers var never gets populated which sets $status to 1 causing the false pos.

(My /var/cpanel/conf/proftpd/main looks like this)

Code: Select all

--- 
MaxInstances: none
TLSCipherSuite: HIGH:MEDIUM:+TLSv1:+SSLv3:-SSLv2
TLSRequired: 'off'
TimeoutIdle: 600
cPanelAnonymousAccessAllowed: 'yes'

[chirpy]

Thanks, I'll check it out.