update to 6.48 reverts to TESTING mode

[coydog]

Hello,

First, I use csf daily, both on my personal servers and at work with a mid-sized VPS hosting company. I appreciate that it is provided free to the community. It makes my life much easier.

I've noticed a problem with the recent update to 6.48. It does not seem to have affected the vast majority of servers where I work with CSF, but it's affected both of my personal servers, and I've observed it on one or two of my customers' VPS's. One of my coworkers has also observed this on at least two or three VPS's.

The issue is that after the update, csf.conf is being reverted to TESTING mode. No other settings appear to be lost or modified. Here is a diff of the pre-update backup from the most recent example I've noticed:
------
root@www:/etc/csf# diff csf.conf*
11c1
< TESTING = "1"
---
> #TESTING = "1"
------

I've observed this on Virtuozzo containers on Centos 6.x:
------
root@sliver [~]# uname -a
Linux sliver.xxxxxxx.xxx 2.6.32-042stab084.14 #1 SMP Fri Mar 21 19:07:05 MSK 2014 x86_64 x86_64 x86_64 GNU/Linux
root@sliver [~]# cat /etc/centos-release
CentOS release 6.5 (Final)
------

I most recently observed the problem on an LXC container with Ubuntu:
------
root@www:/etc/csf# uname -a
Linux xxxxxxxxx.xxx 3.2.0-59-generic #90-Ubuntu SMP Tue Jan 7 22:43:51 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
------

The only common factor I've noticed is that I disable TESTING mode by commenting the line out with '#' rather than setting 'TESTING = "0"'.

In the most recent example, CSF was apparently not running for a couple of weeks after the latest automatic update due to being left in TESTING mode.

I hope this is helpful. Please let me know if you need more information.

Thanks!

[ForumAdmin]

That is not a bug, you should never comment out options in csf.conf, either enable them or disable them.

[coydog]

Hello,

Thanks for the quick response and thank you for clarifying that.

I had actually checked the documentation two or three times to see if this was a documented restriction, but I may have missed something. CSF's other configuration files, such as as csf.blocklists, use commented-out options for example configuration, so I thought this would be valid.

Thanks again for the quick response and for your contributions to the community.