Dear developers,
Webmin is switching to SPA. We need to inject certain triggers for module to operate correctly.
At the moment we have in CSF the ability to inject stuff into head section and before the closing tag (footer).
We also need the ability to add `data-*` attributes to `<html>` tag and most importantly ability to inject tags/containers into the body tag.
Is this possible that you could add to the next version 10.23 mentioned hooks as well, along to other Custom styling, i.e. to existing `csf.header` and `csf.footer`, add something like `csf.body` and `csf.htmldata`, please?
Webmin + CSF
Re: Webmin + CSF
Is this possible to add?
-
ForumAdmin
- Moderator
- Posts: 1524
- Joined: 01 Oct 2008, 09:24
Re: Webmin + CSF
We will look at adding the functionality when csf next comes up for modification.
Re: Webmin + CSF
Thank you very much for the update.
One question though. On read me you state:
I suppose it's not there yet?
At the same time, using csf.footer will be possible to close those starting tags mentioned above.
Adding additional wrappers into <body> is very important and makes things impossible to style fully.
Could you please also add csf.bodycontent or something?
One question though. On read me you state:
What about adding anything in the <body>, like a container <div id="container"><div id="subcontainer">.On non-cPanel servers, added csf.htmltag and csf.bodytag files to UI skinning (STYLE_CUSTOM)
I suppose it's not there yet?
At the same time, using csf.footer will be possible to close those starting tags mentioned above.
Adding additional wrappers into <body> is very important and makes things impossible to style fully.
Could you please also add csf.bodycontent or something?
-
ForumAdmin
- Moderator
- Posts: 1524
- Joined: 01 Oct 2008, 09:24
Re: Webmin + CSF
This has been added in v10.24
Re: Webmin + CSF
Absolutely fantastic. Thanks! <3
Re: Webmin + CSF
Everything it's purely fantastic. I only found one serious obstacle, which is in Configuration Page.
In your `/usr/local/csf/lib/csf.div` you have right at the top:
When using AJAX calls you can't use `document.write` after the page stopped loading (https://stackoverflow.com/questions/23 ... sing-ajax). In our case, it always stopped, because of SPA model, and doing it destroys the whole page completely.
Could you please move this part to `configserver.css` ?
In your `/usr/local/csf/lib/csf.div` you have right at the top:
Code: Select all
document.write ...
Could you please move this part to `configserver.css` ?
Re: Webmin + CSF
One more thing,
Search System Logs/Select for log file name (id="CSFlognum") doesn't seem to need to trigger `CSFrefreshtimer()`.
If it's triggered, then it would cause fatal error because there is no such element on this page.
Search System Logs/Select for log file name (id="CSFlognum") doesn't seem to need to trigger `CSFrefreshtimer()`.
If it's triggered, then it would cause fatal error because there is no such element on this page.
Re: Webmin + CSF
10.25 is perfect - thank you. When I release next theme version I'll send you the link to take a look.